Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ch28772][sentry-6395] Fix pdf export of progress report #1717

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

emaciupe
Copy link
Contributor

[ch28772]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #28772: Export error.

@emaciupe emaciupe requested a review from robertavram March 18, 2022 11:43
@emaciupe emaciupe added the Ready label Mar 18, 2022
@domdinicola domdinicola self-requested a review March 18, 2022 17:46
@domdinicola
Copy link
Contributor

we should check how to handle string values in indicators.. total = {"d": "100", "v": "30"}

1 similar comment
@domdinicola
Copy link
Contributor

we should check how to handle string values in indicators.. total = {"d": "100", "v": "30"}

@domdinicola domdinicola added On hold and removed Ready labels Apr 7, 2022
@emaciupe
Copy link
Contributor Author

we should check how to handle string values in indicators.. total = {"d": "100", "v": "30"}

@domdinicola Data should be saved as int right? But there are strings already saved. So you need to have a script to sanitize the existing data - but I think that is a different card. Current PR is a quick fix so that the export is still possible.

@robertavram robertavram merged commit 051dff5 into develop Jul 18, 2022
@robertavram robertavram deleted the 28772-export-decimal-error branch July 18, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants