Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ch26694] allow zero reports #1650

Merged
merged 1 commit into from
Jan 6, 2022
Merged

[ch26694] allow zero reports #1650

merged 1 commit into from
Jan 6, 2022

Conversation

robertavram
Copy link
Member

@robertavram robertavram commented Nov 29, 2021 •
edited
Loading

[ch26694]

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #26694: Partner is not able to submit report for percentage indicator with zero achievement.

@domdinicola domdinicola changed the title allow zero reports [ch26694] allow zero reports Dec 10, 2021
@domdinicola domdinicola requested a review from emaciupe January 5, 2022 00:59
emaciupe
emaciupe approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@emaciupe emaciupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: Keeping the for-loop counter variable name to location_disaggregation is a bit misleading, as now the queryset has IndicatorLocationData objects instead of disaggrations.

@robertavram robertavram merged commit 05f6230 into develop Jan 6, 2022
@robertavram robertavram deleted the fix_zero_reports branch January 6, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emaciupe emaciupe emaciupe approved these changes

Assignees
No one assigned
Labels
Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertavram @emaciupe @domdinicola