Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for tabsearch, QR generator, and grab handle #1591

Merged
merged 3 commits into from
Aug 22, 2021

Conversation

Ahrotahn
Copy link
Contributor

@Ahrotahn Ahrotahn commented Aug 5, 2021

This PR contains two commits, the first adds a flag that removes the tabsearch button (and it's keyboard shortcut), the second adds a flag to disable the QR generator for sharing page links.

Fixes #1553 and #1574

PF4Public added a commit to PF4Public/gentoo-overlay that referenced this pull request Aug 5, 2021
…1591

Package-Manager: Portage-3.0.20, Repoman-3.0.2
RepoMan-Options: --force
@PF4Public
Copy link
Contributor

Awesome!
image
image

Did you avoid removing this empty padding on purpose? Could it be also incorporated into the patch?

@Ahrotahn
Copy link
Contributor Author

Ahrotahn commented Aug 6, 2021

I have a separate patch for removing the drag handle space, but I needed to do some more testing before submitting it.
It turns out that the flex layout compresses the tip marquee's space regardless of it's preferred size and the added padding, so the only change needed is the resizing of the handle.

I'll add that patch to the PR soon once I get some time. @Eloston I hope you don't mind me grouping up these patches like this! Doing it this way makes it so that their merge order doesn't need to be considered since the flags need to be added sequentially.

@Ahrotahn Ahrotahn changed the title Add flags for tabsearch and QR generator Add flags for tabsearch, QR generator, and grab handle Aug 6, 2021
@PF4Public
Copy link
Contributor

With the last patch it looks like this:
image

@Eloston
Copy link
Member

Eloston commented Aug 22, 2021

@Eloston I hope you don't mind me grouping up these patches like this! Doing it this way makes it so that their merge order doesn't need to be considered since the flags need to be added sequentially.

I don't mind, thanks for letting me know!

Copy link
Member

@Eloston Eloston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the tab search feature
3 participants