-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toml + Tox Migration #270
Toml + Tox Migration #270
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #270 +/- ##
=======================================
Coverage 92.87% 92.87%
=======================================
Files 60 60
Lines 3200 3200
=======================================
Hits 2972 2972
Misses 228 228 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments. Once resolved I will go about testing the installations.
CONTRIBUTING.md
Outdated
pytest | ||
# To list all test environments, run: | ||
python3 -m tox list | ||
# To execute all test environments run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment on different commands
scripts/github_release.sh
Outdated
@@ -0,0 +1,35 @@ | |||
#!/usr/bin/env zsh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you provide a source to this file to how this file was developed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not clear to me how this file is used, how is the tag chosen by the user?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd choose tag, e.g., v.4.0.2
and run ./scripts/github_release v.4.0.2
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, can you add that running instructions ./scripts/github_release v.4.0.2
including all the build step, as a subsection in https://quantus.readthedocs.io/en/latest/docs_dev/CONTRIBUTING.html?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this gitub_release.sh
can you provide a source to this file as a comment (to how this file was developed)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tbh, I am not a big fan of this script either. Let's try to catch up in the following days, and talk about how would you want to organize the release process.
scripts/github_release.sh
Outdated
@@ -0,0 +1,35 @@ | |||
#!/usr/bin/env zsh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this gitub_release.sh
can you provide a source to this file as a comment (to how this file was developed)?
There is a discrepancy betwee git clone https://github.com/understandable-machine-intelligence-lab/Quantus.git
cd quantus
pip install -r requirements_test.txt
pip install -e . |
I'll update this and push it. |
Description
setup.py
install to recommended bypypa
(the team behindpipy
) pyproject.toml, build and filt-core as build backend.tox.ini
. Tox has nothing to do with packaging, it is used for test automation. At this point, the benefit is minimal, but this is a prerequisite for "integration testing". Tox will allow us to create different isolated environments with or without TensorFlow, which will help us ensure Quantus is usable in all of it'sdifferent installation variants.
Implemented changes
setup.py
withpyproject.toml
tox.ini
, add testing, linting, coverage configurations to it.Minimum acceptance criteria
./scripts/github_release.sh
.