Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor misleading error message in Robustness metrics #227

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

dilyabareeva
Copy link
Collaborator

@dilyabareeva dilyabareeva commented Feb 9, 2023

Description

  • When failing to provide an explain_func for the robustness metrics, an error message states AssertionError: Make sure 'explain_func' is a Callable that takes model, x_batch, y_batch and **kwargs as arguments. However, the correct signature for explain_func is model, inputs, targets and **kwargs.
  • This PR fixes the issue
  • Address the issue Minor misleading error message in Robustness metrics #201.

Implemented changes

  • Fix the comment.

Copy link
Member

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@annahedstroem annahedstroem merged commit 486923e into main Feb 13, 2023
@aaarrti aaarrti deleted the issue_201 branch March 18, 2023 17:46
aaarrti pushed a commit that referenced this pull request Apr 9, 2023
…issue_201

Fix minor misleading error message in Robustness metrics
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants