Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mock model for return_nan_when_prediction_changes tests #219

Closed
aaarrti opened this issue Jan 9, 2023 · 4 comments · Fixed by #241
Closed

Mock model for return_nan_when_prediction_changes tests #219

aaarrti opened this issue Jan 9, 2023 · 4 comments · Fixed by #241
Assignees
Labels
bug Something isn't working

Comments

@aaarrti
Copy link
Collaborator

aaarrti commented Jan 9, 2023

Description

  • The tests for return_nan_when_prediction_changes parameter rely on high noise amplitudes, however if the predictions actually change is still not deterministic, and occasionally the tests will fail because of it.

Steps to reproduce the behavior

  • Mock models outputs for tests with return_nan_when_prediction_changes=True
@aaarrti aaarrti self-assigned this Jan 9, 2023
@aaarrti
Copy link
Collaborator Author

aaarrti commented Jan 24, 2023

image

@aaarrti aaarrti added the bug Something isn't working label Mar 18, 2023
@aaarrti aaarrti mentioned this issue Mar 18, 2023
2 tasks
@annahedstroem
Copy link
Member

Hi @aaarrti

What is meant by "however if the predictions actually change is still not deterministic, and occasionally the tests will fail because of it."? Do you mean that it is hard to predict if a model sometimes doesn't return the same predicted class after perturbation? Why will a test fail because of this?

Thank you!

@aaarrti
Copy link
Collaborator Author

aaarrti commented Mar 25, 2023

Hi @aaarrti

What is meant by "however if the predictions actually change is still not deterministic, and occasionally the tests will fail because of it."? Do you mean that it is hard to predict if a model sometimes doesn't return the same predicted class after perturbation? Why will a test fail because of this?

Thank you!

It means, if this test was run, e.g., 100 times, it will fail once or twice

@aaarrti
Copy link
Collaborator Author

aaarrti commented Mar 25, 2023

annahedstroem added a commit that referenced this issue Mar 31, 2023
aaarrti pushed a commit that referenced this issue Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants