Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed s group edits with subscription #43

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

davidye-uncountable
Copy link

Duplicates https://github.com/epam/ketcher/pull/5993/files from the main ketcher repo.
When we merge ketcher back in, this PR should become obsolete.

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

Copy link
Collaborator

@martinuncountable martinuncountable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after talking this through live, this makes sense.

@martinuncountable martinuncountable merged commit 6102fb8 into master Mar 4, 2025
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants