add string support to if statement #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leb2
reviewed
Nov 10, 2023
| ): | ||
| then_str = np.array(then, dtype="U") | ||
| otherwise_str = np.array(otherwise, dtype="U") | ||
| return np.where(np.array(test, dtype="b"), then_str, otherwise_str) |
There was a problem hiding this comment.
This seems like a good strategy. I'll test to see if this np.array strategy works on our platform, but it also looks like it shouldn't cause any regressions because of the type checks you are doing.
leb2
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did some testing on master with an output of type TEXT_CALCULATION and a formula like
if(a > 10, "b", "Cccc")for any numeric output a.I had to change my requirements.txt on master to
and reinstall the dependencies with pip to test the library.