Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle tensor inputs to ceiling function #30

Merged
merged 3 commits into from
Oct 25, 2023

Conversation

catherinelasersohn
Copy link

adds support for tensor inputs to the ceiling function


positive_significance = significance > 0
significance = abs(significance)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the old code is doing abs(significance) here. Do you need that in your code as well?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks i fixed this

Copy link
Collaborator

@leb2 leb2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conversion to torch looks correct to me.

I'm not sure if the abs is needed or not, but if it was not intentional to remove it then you can put it back

@catherinelasersohn catherinelasersohn merged commit 4828d52 into master Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants