fix gridlines on filled surfaces #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
reviewed
Apr 13, 2022
| @@ -277,13 +277,13 @@ export class Surface extends Primitive { | |||
| this.wireColor.copy(color); | |||
| if (fill) { | |||
| const c = this.wireScratch; | |||
| c.setRGB(color.x, color.y, color.z); | |||
| c.setRGB(color.r, color.g, color.b); | |||
sritchie
approved these changes
Apr 13, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related issue? #25
#25 is mostly about shaded surfaces being too dark, but we also noticed a gridline issue there, too.
What does this PR do?
In #25 we noted that recent versions of mathbox (including znah's ThreeJS r84 fork) have black gridlines. This fixes that issue.
v0.0.5 Gridlines exactly same color as surface, so not visible unless surface is shaded. From the code in 0.0.5 it's clear the intent was to darken the gridlines, but this appears not to have been working in 0.0.5
v2.1.3 Black gridlines in all cases. Also darker shaded surface; see #26
This branch Gridlines of proper color; darker surface will be fixed by #26
