Merge branch 'sritchie/last_warnings' into 'master'

Fix last eslint warnings See merge request unconed/mathbox!14
unconed · Feb 17, 2022 · 0c13279 · 0c13279
2 parents d97df0c + 6a8ead7
commit 0c13279
Show file tree

Hide file tree

Showing 8 changed files with 22 additions and 20 deletions.
diff --git a/build/mathbox-bundle.js b/build/mathbox-bundle.js
@@ -46205,9 +46205,9 @@ const formatPrimes = [
 ];
 
 const prettyNumber = function (options) {
-  let cache, compact, e, pi, precision, tau, threshold;
+  let cache, compact, e, pi, tau;
   if (options) {
-    ({ cache, compact, tau, pi, e, threshold, precision } = options);
+    ({ cache, compact, tau, pi, e } = options);
   }
 
   compact = +!!(compact != null ? compact : true);
@@ -46454,7 +46454,8 @@ const prettyFormat = function (str) {
 
   str = escapeHTML(str);
 
-  for (let arg of Array.from(args)) {
+  // eslint-disable-next-line no-unused-vars
+  for (let _arg of Array.from(args)) {
     str = str.replace(/%([a-z])/, function (_, f) {
       const v = args.shift();
       switch (f) {
@@ -68062,7 +68063,7 @@ class TextAtlas extends Atlas {
   }
 
   draw(text) {
-    let data, i, imageData, j;
+    let data, i, j;
     let w = this.width;
     const h = this.lineHeight;
     const o = this.outline;
@@ -68086,7 +68087,7 @@ class TextAtlas extends Atlas {
       // Alpha sprite (fast)
       let asc, end;
       ctx.fillText(text, x, y);
-      ({ data } = imageData = ctx.getImageData(0, 0, w, h));
+      ({ data } = ctx.getImageData(0, 0, w, h));
       j = 3; // Skip to alpha channel
       for (
         i = 0, end = data.length / 4, asc = 0 <= end;
@@ -68124,7 +68125,7 @@ class TextAtlas extends Atlas {
       ctx.fillText(text, x, y);
 
       // Pull image data
-      ({ data } = imageData = ctx.getImageData(0, 0, w, h));
+      ({ data } = ctx.getImageData(0, 0, w, h));
       j = 0;
       const { gamma } = this;
 
@@ -72880,7 +72881,7 @@ class Animation {
       invalid = true;
       return null;
     });
-    if (value !== undefined) {
+    if (value !== undefined && !invalid) {
       target = value;
     }
 
@@ -73655,7 +73656,7 @@ Context.initClass();
 
 
 
-const version = "2.0.0";
+const version = "2.1.0";
 
 // Just because
 const π = Math.PI;

diff --git a/build/mathbox-bundle.js.map b/build/mathbox-bundle.js.map
diff --git a/build/mathbox.min.js b/build/mathbox.min.js
diff --git a/build/mathbox.min.js.map b/build/mathbox.min.js.map
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/render/buffer/textatlas.js b/src/render/buffer/textatlas.js
@@ -164,7 +164,7 @@ export class TextAtlas extends Atlas {
   }
 
   draw(text) {
-    let data, i, imageData, j;
+    let data, i, j;
     let w = this.width;
     const h = this.lineHeight;
     const o = this.outline;
@@ -188,7 +188,7 @@ export class TextAtlas extends Atlas {
       // Alpha sprite (fast)
       let asc, end;
       ctx.fillText(text, x, y);
-      ({ data } = imageData = ctx.getImageData(0, 0, w, h));
+      ({ data } = ctx.getImageData(0, 0, w, h));
       j = 3; // Skip to alpha channel
       for (
         i = 0, end = data.length / 4, asc = 0 <= end;
@@ -226,7 +226,7 @@ export class TextAtlas extends Atlas {
       ctx.fillText(text, x, y);
 
       // Pull image data
-      ({ data } = imageData = ctx.getImageData(0, 0, w, h));
+      ({ data } = ctx.getImageData(0, 0, w, h));
       j = 0;
       const { gamma } = this;
 

diff --git a/src/stage/animator.js b/src/stage/animator.js
@@ -189,7 +189,7 @@ class Animation {
       invalid = true;
       return null;
     });
-    if (value !== undefined) {
+    if (value !== undefined && !invalid) {
       target = value;
     }
 

diff --git a/src/util/pretty.js b/src/util/pretty.js
@@ -66,9 +66,9 @@ const formatPrimes = [
 ];
 
 const prettyNumber = function (options) {
-  let cache, compact, e, pi, precision, tau, threshold;
+  let cache, compact, e, pi, tau;
   if (options) {
-    ({ cache, compact, tau, pi, e, threshold, precision } = options);
+    ({ cache, compact, tau, pi, e } = options);
   }
 
   compact = +!!(compact != null ? compact : true);
@@ -315,7 +315,8 @@ const prettyFormat = function (str) {
 
   str = escapeHTML(str);
 
-  for (let arg of Array.from(args)) {
+  // eslint-disable-next-line no-unused-vars
+  for (let _arg of Array.from(args)) {
     str = str.replace(/%([a-z])/, function (_, f) {
       const v = args.shift();
       switch (f) {