-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add support for type transformations to node runner #204
Conversation
🦋 Changeset detectedLatest commit: d9bdf47 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 96.26% 97.41% +1.14%
==========================================
Files 1 1
Lines 241 232 -9
Branches 118 110 -8
==========================================
- Hits 232 226 -6
+ Misses 9 6 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@JounQin I saw that you changed This is problematic because it will then also apply for supported versions if the flag isnt passed or no-experimental-strip-types is set. We only want to throw when the flag isn't present, aka in node versions prior to v22.10. |
@JounQin Yes, when running v22.10 without any flags, this value will be false. This means we are currently throwing an error. In v23.6+ this flag will be false when |
OK, I understand a bit now, |
But shouldn't we add I'm going to not using this feature flag. |
@JounQin Yep, the drawback of using this flag is dropping support for |
@nwidynski Please help to review https://github.com/un-ts/synckit/pull/211/files |
Unfortunately I noticed this feature was only introduced on the 6th minor release of v22 & v23. We should take this into consideration properly. https://nodejs.org/en/blog/release/v22.6.0 & https://nodejs.org/en/blog/release/v23.6.0
I also learned today, that Node has feature flags, which also include one for typescript. Sorry for not checking this earlier.