-
-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use named exports #982
use named exports #982
Conversation
size-limit report 📦
|
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
+ Coverage 43.85% 43.98% +0.13%
==========================================
Files 129 127 -2
Lines 2921 2903 -18
Branches 657 662 +5
==========================================
- Hits 1281 1277 -4
+ Misses 1627 1613 -14
Partials 13 13
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
another conflict |
We need to merge #894 because it could increase the number of the conflicts and fix them after it. |
I noticed an inconsistency when modules are using default naming. Even I sometimes rename imported module and then it's hard to read or refactor code. Here are other reasons why it's good.
I tried to use named imports and check if it makes an impact on bundle size and it's not.