-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the ability to configure the 'simple_view' parameter from the cli… #963
add the ability to configure the 'simple_view' parameter from the cli… #963
Conversation
@Yuriy-Karpov Hey! Thank you for contributing to the project. |
Codecov Report
@@ Coverage Diff @@
## master #963 +/- ##
==========================================
+ Coverage 43.15% 43.29% +0.14%
==========================================
Files 127 128 +1
Lines 2621 2633 +12
Branches 519 522 +3
==========================================
+ Hits 1131 1140 +9
- Misses 1444 1447 +3
Partials 46 46
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thx. Could you, pls rebase those commits into one? I can squash it, but as far as I recall it will show the result under my name, which is confusing |
@Yuriy-Karpov gentle ping: as soon as you'll rebase\squash everything into a single commit, it will be merged and likely will get into release v1.8.0. |
I apologize for the late response, I will do everything now |
…ent, the parameter is not required, but if set, it will overwrite the one that came from the backend issues-916
4198ab4
to
4dcba85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
added the ability to configure the 'simple_view' parameter from the client,
the parameter is not required, but if set, it will overwrite the one that came from the backend
#916