Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add message of image upload try by anonymous user #691

Merged
merged 5 commits into from
Apr 20, 2020
Merged

Add message of image upload try by anonymous user #691

merged 5 commits into from
Apr 20, 2020

Conversation

dellink
Copy link
Contributor

@dellink dellink commented Apr 18, 2020 •
edited by paskal
Loading

fix #661
Screen Shot 2020-04-18 at 17 29 24

@dellink dellink requested a review from umputun as a code owner April 18, 2020 14:30
@dellink dellink changed the title Add message of image upload try by anonymous user #661 Add message of image upload try by anonymous user (#661) Apr 18, 2020
@dellink dellink changed the title Add message of image upload try by anonymous user (#661) Add message of image upload try by anonymous user Apr 18, 2020
@paskal paskal requested review from akellbl4 and Mavrin April 18, 2020 15:47
akellbl4
akellbl4 requested changes Apr 19, 2020
View reviewed changes
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
Would you be so kind as to add tests to your changes?

frontend/app/components/comment-form/comment-form.tsx Show resolved Hide resolved
frontend/app/locales/de.json Outdated Show resolved Hide resolved
@dellink dellink requested a review from akellbl4 April 19, 2020 17:46
@akellbl4
Copy link
Collaborator

Almost done. You fixed message getting and you should regenerate translations. After that, you will see a new translation line in JSON.

@dellink dellink requested a review from akellbl4 April 20, 2020 08:25
akellbl4
akellbl4 approved these changes Apr 20, 2020
View reviewed changes
Copy link
Collaborator

@akellbl4 akellbl4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thank you for your contribution.

umputun
umputun approved these changes Apr 20, 2020
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx

@umputun umputun merged commit cb54d0e into umputun:master Apr 20, 2020
@dellink dellink deleted the add-error-message-for-anonymous-in-comment-form branch April 21, 2020 11:54
@paskal paskal added this to the v1.6 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akellbl4 akellbl4 akellbl4 approved these changes

@umputun umputun umputun approved these changes

@Mavrin Mavrin Awaiting requested review from Mavrin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

Lack of message in case of image upload try by anonymous user
4 participants
@dellink @akellbl4 @umputun @paskal