notify/email.go: fixup smtp.NewClient second param #681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
second param is wrong
most time it does not effact the result, but when you are connecting to a localhost smtp server with
PLAIN AUTH enabled but without TLS enabled. it will fail
I also marked this problem in my smtp-brd FAQ
the important part is
localhost
, if your send itlocalhost:25
or other addr with port, it will fail.