Frontend scripts and docs updates #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rename and combine npm scripts * move to checkout@v2 in actions * change dev docs * move liststaged config to package.json because it easier to understand what husky doing
akellbl4
commented
Apr 13, 2020
| @@ -51,7 +51,7 @@ ARG NODE_ENV=production | |||
| COPY --from=build-frontend-deps /srv/frontend/node_modules /srv/frontend/node_modules | |||
| ADD frontend /srv/frontend | |||
| RUN cd /srv/frontend && \ | |||
| if [ -z "$SKIP_FRONTEND_TEST" ] ; then npx run-p check lint lint:style test build ; \ | |||
| if [ -z "$SKIP_FRONTEND_TEST" ] ; then npx run-p lint test check; \ | |||
There was a problem hiding this comment.
npm run check builds bundle underhood for checking size
akellbl4
commented
Apr 13, 2020
| @@ -587,6 +587,10 @@ It stars backend service with embedded bolt store on port `8080` with basic auth | |||
|
|
|||
| ### Frontend development | |||
|
|
|||
| #### Developer guide | |||
|
|
|||
| Frontend guide can be found here: [./frontend/Readme.md](./frontend/Readme.md) | |||
There was a problem hiding this comment.
Moved it above because it is good to read first "how" instead of "what" you should do
paskal
previously approved these changes
Apr 13, 2020
|
@Mavrin as we discussed offline I moved configs to separate files and add instant commands |
Mavrin
approved these changes
Apr 13, 2020
umputun
approved these changes
Apr 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good to rebase and merge after merging of #671