Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple tests fixes #675

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Multiple tests fixes #675

merged 3 commits into from
Apr 13, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Apr 13, 2020 •
edited
Loading

  • add -race key to backend tests in CI pipeline and Dockerfile
  • remove log package usage from tests, sort imports
  • fix image.Close infinite wait on empty image.submitCh, as well as infinite wait and non-deterministic result on more than one image waiting in image.submitCh.

@paskal paskal requested a review from umputun as a code owner April 13, 2020 09:44
@paskal paskal added the backend label Apr 13, 2020
@github-actions
Copy link

Pull Request Test Coverage Report for Build a1aa5c65c-PR-675

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 83.412%
Totals Coverage Status
Change from base Build a15acaf29: 0.03%
Covered Lines: 5139
Relevant Lines: 6161
💛 - Coveralls

@paskal paskal force-pushed the tests_fixes branch 2 times, most recently from 339ea0d to 3ec00e6 Compare April 13, 2020 10:56
umputun
umputun approved these changes Apr 13, 2020
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit 4605d56 into master Apr 13, 2020
@umputun umputun deleted the tests_fixes branch April 13, 2020 21:01
@umputun umputun added this to the v1.6 milestone Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@paskal @umputun