Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image interface changes #623

Merged
merged 6 commits into from
Mar 23, 2020
Merged

Image interface changes #623

merged 6 commits into from
Mar 23, 2020

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Mar 22, 2020 •
edited
Loading

Multiple preparations before implementing #572 which I don't want to mess up into image RPC implementation PR.

  • sort imports in memory_store for consistency
  • add a missing copyright notice to rpc.go file
  • make all image.Store interface functions public: otherwise, it's impossible to use this interface from another package:
    image
  • make image.Store.Load return []byte instead of io.ReadCloser
  • regenerate mock files in remark42 backend (for image and engine)
  • go mod tidy in memory_store changes to go.mod
  • divide memory_store RPC server to multiple files by handlers, as new one would be added and single file feels to be too big for that

@paskal paskal added the backend label Mar 22, 2020
@paskal paskal requested a review from umputun March 22, 2020 17:32
@paskal paskal force-pushed the image_interface_fixes branch from 235d62b to 06c8d6f Compare March 22, 2020 17:37
Repository owner deleted a comment from golangcibot Mar 22, 2020
@paskal paskal force-pushed the image_interface_fixes branch from 06c8d6f to 123df0b Compare March 22, 2020 17:44
@paskal paskal force-pushed the image_interface_fixes branch from 898d5e2 to 3b132db Compare March 22, 2020 20:45
@paskal paskal mentioned this pull request Mar 22, 2020
Merged
@paskal paskal changed the title Image interface fixes Image interface changes Mar 23, 2020
umputun
umputun approved these changes Mar 23, 2020
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit c9a2369 into master Mar 23, 2020
@umputun umputun deleted the image_interface_fixes branch March 23, 2020 01:43
@umputun umputun added this to the v1.6 milestone Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun approved these changes

Assignees
No one assigned
Labels
backend
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
2 participants
@paskal @umputun