Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bolt image store #450

Closed
wants to merge 3 commits into from
Closed

Conversation

smaant
Copy link
Collaborator

@smaant smaant commented Oct 20, 2019

Implementation notes

  1. Moved image preprocessing into service. Feels like it shouldn't be a storage specific.
  2. For image committing/cleanup use additional bucket with (metas) which collects ids of staged images by time of addition. Cleanup takes a range from some old date till now - TTL and removes referenced images. This particular approach was chosen because of bolt limitation of only a single read-write transaction. Interval between cleanups might be pretty long (depends on configuration) therefore it might be possible to have quite a big list of staged images, so objective was to avoid iterating over entire list of staged images.

backend/app/store/image/bolt.go Outdated Show resolved Hide resolved
backend/app/store/image/bolt.go Outdated Show resolved Hide resolved
backend/app/store/image/bolt_test.go Outdated Show resolved Hide resolved
@umputun
Copy link
Owner

umputun commented Oct 22, 2019

thx for the PR. I have already merged #449, so closing this one

@umputun umputun closed this Oct 22, 2019
@umputun umputun added this to the v1.5 milestone Jan 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants