Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use GitHub actions as ci #434

Merged
merged 13 commits into from
Sep 20, 2019
Merged

Use GitHub actions as ci #434

merged 13 commits into from
Sep 20, 2019

Conversation

Smolevich
Copy link
Contributor

  • Add support Github Actions (copy build docker image from .travis.yml)
  • For correct work with coveralls.io in secrets should setted COVERALLS_TOKEN

@Smolevich Smolevich mentioned this pull request Sep 20, 2019
Closed
umputun
umputun reviewed Sep 20, 2019
View reviewed changes
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. Added a few questions

.github/workflows/blank.yml Show resolved Hide resolved
.github/workflows/blank.yml Show resolved Hide resolved
Dockerfile Show resolved Hide resolved
@umputun umputun merged commit 4f6c336 into umputun:master Sep 20, 2019
@umputun
Copy link
Owner

umputun commented Sep 20, 2019

I have merged it but looks like DEBUG is not that optional

wuvye-201909-20135304-yhpbj

@Smolevich
Copy link
Contributor Author

@umputun, I prepare fix

@umputun
Copy link
Owner

umputun commented Sep 20, 2019

hmm, smth still confusing coveralls. For build from actions it shows 80% in some places, i.e. https://coveralls.io/jobs/53503811 The same build from travis looks correct https://coveralls.io/builds/25839972

@Smolevich Smolevich mentioned this pull request Jan 20, 2020
Closed
@paskal paskal added this to the v1.5 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun umputun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@Smolevich @umputun @paskal