Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing Korean and Japanese translations for updated English text #1723

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

NavyStack
Copy link
Contributor

Korean translation is provided "as is".

  • Rearranged the word order to better match Korean sentiment.
  • Made adjustments to clarify subtle semantic differences in the original text, which may have identical translations in Korean.
  • We have striven to maintain the original sentence structure as closely as possible.
  • If the original text lacks a period, the translation into Korean also omits it, rendering the content as a short phrase rather than a full sentence.

@NavyStack NavyStack requested a review from umputun as a code owner January 8, 2024 03:12
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (676ae77) 61.52% compared to head (6ee68c8) 61.52%.
Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1723    +/-   ##
========================================
  Coverage   61.52%   61.52%            
========================================
  Files         133      133            
  Lines        3002     3002            
  Branches      715      757    +42     
========================================
  Hits         1847     1847            
+ Misses       1151     1038   -113     
- Partials        4      117   +113     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NavyStack NavyStack changed the title fix: Add missing Korean translations for updated English text fix: Add missing Korean and Japanese translations for updated English text Jan 8, 2024
@NavyStack
Copy link
Contributor Author

Japanese translation also provided "as is".

  • Add missing Japanese translation.

@umputun umputun merged commit 3f14651 into umputun:master Jan 8, 2024
9 checks passed
@paskal paskal added this to the v1.13.0 milestone Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants