Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable color-scheme on remark iframe #1429

Merged
merged 1 commit into from
Aug 10, 2022
Merged

disable color-scheme on remark iframe #1429

merged 1 commit into from
Aug 10, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Jul 22, 2022

In order to prevent problems like so #1421 we need to disable color-scheme for the iframe.
We can remove this line when support for color-scheme is implemented inside widget.

Issue for full support: #1430

@akellbl4 akellbl4 requested a review from umputun as a code owner July 22, 2022 02:45
@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #1429 (245ff26) into master (3d1a3fd) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1429   +/-   ##
=======================================
  Coverage   58.12%   58.12%           
=======================================
  Files         131      131           
  Lines        2909     2909           
  Branches      743      743           
=======================================
  Hits         1691     1691           
  Misses       1087     1087           
  Partials      131      131           
Impacted Files Coverage Δ
frontend/apps/remark42/app/utils/create-iframe.ts 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d1a3fd...245ff26. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 2.03 KB (+0.44% 🔺)
public/remark.mjs 72.37 KB (0%)
public/remark.css 8.2 KB (0%)
public/last-comments.mjs 35.51 KB (0%)
public/last-comments.css 3.79 KB (0%)
public/deleteme.mjs 12.05 KB (0%)
public/counter.mjs 749 B (0%)

@akellbl4 akellbl4 requested a review from Mavrin July 22, 2022 02:52
@akellbl4 akellbl4 merged commit 7e0445c into master Aug 10, 2022
@akellbl4 akellbl4 deleted the fix-color-scheme branch August 10, 2022 17:20
@paskal paskal added this to the v1.10.2 milestone Aug 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants