Return docker build for frontend and backend code outside master in CI #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akellbl4
previously approved these changes
Jul 19, 2022
paskal
force-pushed
the
dverhoturov/docker_ci_build
branch
2 times, most recently
from
17d3e11 to
6593059
Compare
Pull Request Test Coverage Report for Build 2701375423
💛 - Coveralls |
paskal
force-pushed
the
dverhoturov/docker_ci_build
branch
7 times, most recently
from
fd6413b to
167060f
Compare
paskal
force-pushed
the
dverhoturov/docker_ci_build
branch
from
167060f to
f9b4373
Compare
paskal
force-pushed
the
dverhoturov/docker_ci_build
branch
from
f9b4373 to
473e948
Compare
Previously we built a Docker image just for the test, but the introduction of multi-arch build in 9fbf095 build also meant the push of the image, so it was restricted only to the master branch. This change re-introduces the Docker image build outside the master branch, which is helpful in pull requests. We recently had a few frontend PRs which broke the Docker image build silently, and that change prevents it from happening.
paskal
force-pushed
the
dverhoturov/docker_ci_build
branch
from
473e948 to
21550db
Compare
Merged
paskal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we built a Docker image just for the test, but the introduction of multi-arch build in 9fbf095 build also meant the push of the image, so it was restricted only to the master branch. This change re-introduces the Docker image build outside the master branch, which is helpful in pull requests.
We recently had a few frontend PRs which broke the Docker image build silently, and that change prevents it from happening.