-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to pnpm #1404
Switch to pnpm #1404
Conversation
36c3fea
to
6e0aca7
Compare
Codecov Report
@@ Coverage Diff @@
## master #1404 +/- ##
==========================================
+ Coverage 58.00% 58.17% +0.17%
==========================================
Files 131 131
Lines 2900 2905 +5
Branches 699 735 +36
==========================================
+ Hits 1682 1690 +8
+ Misses 1214 1211 -3
Partials 4 4
Continue to review full report at Codecov.
|
RUN if [ -z "$SKIP_FRONTEND_BUILD" ] ; then \ | ||
CI=true npm ci --loglevel warn \ | ||
npm i -g pnpm && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can use https://nodejs.org/api/corepack.html for activate pnpm
corepack pnpm install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think its too early for corepack
. It was introduced in v18 and it's experimental.
But worth considering when we move towards update to node18
UPD: Oh, I'm wrong it's available in v16.
node_modules
sizeIt's okay that size job is failing. It's because it can't install dependencies on master without
pnpm-lock.yml