Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email auth validation with middleware #1377

Merged
merged 5 commits into from
Jun 5, 2022
Merged

add email auth validation with middleware #1377

merged 5 commits into from
Jun 5, 2022

Conversation

umputun
Copy link
Owner

@umputun umputun commented Jun 3, 2022

PR adds a middleware checking "user" query param similarly to the current UI implementation, with ^[\p{L}\d\s_]{4,64}$ regex.

This is needed to prevent direct API calls from sending non-sanitized data into /auth/email/login endpoint. Also, see related PR in auth lib

@umputun umputun requested review from akellbl4 and paskal June 3, 2022 23:18
@coveralls
Copy link

coveralls commented Jun 3, 2022

Pull Request Test Coverage Report for Build 2440411171

  • 32 of 32 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 84.056%

Totals Coverage Status
Change from base Build 2429336973: 0.07%
Covered Lines: 5741
Relevant Lines: 6830

💛 - Coveralls

@umputun umputun merged commit 6f81bf0 into master Jun 5, 2022
@umputun umputun deleted the valid-email-auth branch June 5, 2022 16:57
@paskal paskal added this to the v1.10.1 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants