Improve tests reliability #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, go.uber.org/goleak reports leaking goroutine caused by HTTP client on many tests when ran one by one.
paskal
force-pushed
the
paskal/tests_cleanup
branch
from
36149ea to
588cb4a
Compare
Pull Request Test Coverage Report for Build 2246072358
💛 - Coveralls |
umputun
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/tmpafter integrational testshttpclients, as without thisgo.uber.org/goleakreports leaking goroutine caused by HTTP client on many tests when ran one by one.