Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for telegram auth #1269

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fixes for telegram auth #1269

merged 1 commit into from
Feb 11, 2022

Conversation

akellbl4
Copy link
Collaborator

@akellbl4 akellbl4 commented Feb 10, 2022

  • fix type for an error in fetcher
  • use is-object func for checks
  • better error handling for auth requests

- fix type for an error in fetcher
- use is-object func for checks
- better error handling for auth requests
@akellbl4 akellbl4 requested a review from umputun as a code owner February 10, 2022 19:58
@akellbl4 akellbl4 requested review from Mavrin and paskal February 10, 2022 19:59
@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #1269 (3ec52f6) into master (74b47d3) will increase coverage by 0.00%.
The diff coverage is 69.69%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1269   +/-   ##
=======================================
  Coverage   48.45%   48.46%           
=======================================
  Files         135      136    +1     
  Lines        3042     3060   +18     
  Branches      680      686    +6     
=======================================
+ Hits         1474     1483    +9     
- Misses       1558     1566    +8     
- Partials       10       11    +1     
Impacted Files Coverage Δ
frontend/app/components/auth/auth.messsages.ts 100.00% <ø> (ø)
frontend/app/components/auth/auth.tsx 80.57% <60.00%> (-2.76%) ⬇️
frontend/app/components/auth/auth.hooks.ts 92.40% <69.23%> (-4.78%) ⬇️
frontend/app/common/fetcher.ts 94.82% <100.00%> (ø)
frontend/app/common/local-storage.ts 78.04% <100.00%> (+0.54%) ⬆️
frontend/app/utils/is-object.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74b47d3...3ec52f6. Read the comment docs.

@github-actions
Copy link

size-limit report 📦

Path Size
public/embed.mjs 1.89 KB (0%)
public/remark.mjs 67.28 KB (+0.09% 🔺)
public/remark.css 9.21 KB (+0.08% 🔺)
public/last-comments.mjs 30.16 KB (+0.02% 🔺)
public/last-comments.css 4.7 KB (0%)
public/deleteme.mjs 9.79 KB (0%)
public/counter.mjs 601 B (0%)

@umputun umputun merged commit 9bae155 into master Feb 11, 2022
@umputun umputun deleted the telegram-fixes branch February 11, 2022 16:59
@paskal paskal added this to the 1.10.0 milestone Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants