Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve telegram notifications #1162

Merged
merged 1 commit into from
Nov 1, 2021
Merged

Improve telegram notifications #1162

merged 1 commit into from
Nov 1, 2021

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Oct 29, 2021

These changes are designed to ease the transition into the simplified telegram notifications verification model, proposed in #1160.

@paskal paskal added the backend label Oct 29, 2021
@paskal paskal requested a review from umputun October 29, 2021 16:48
@paskal paskal force-pushed the paskal/telegram_notify branch from 3587eaa to 61c538c Compare October 29, 2021 16:52
@coveralls
Copy link

coveralls commented Oct 29, 2021

Pull Request Test Coverage Report for Build 1404547682

  • 74 of 83 (89.16%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 83.896%

Changes Missing Coverage Covered Lines Changed/Added Lines %
backend/app/notify/telegram.go 59 61 96.72%
backend/app/cmd/server.go 15 22 68.18%
Files with Coverage Reduction New Missed Lines %
backend/app/notify/notify.go 2 92.45%
Totals Coverage Status
Change from base Build 1399837379: 0.1%
Covered Lines: 5835
Relevant Lines: 6955

💛 - Coveralls

@paskal paskal force-pushed the paskal/telegram_notify branch from 61c538c to 26f06e2 Compare October 31, 2021 11:18
These changes are designed to ease the transition into
the simplified telegram notifications verification model.
@paskal paskal force-pushed the paskal/telegram_notify branch from 26f06e2 to 21644f2 Compare November 1, 2021 19:31
@paskal paskal requested a review from umputun November 1, 2021 19:31
Copy link
Owner

@umputun umputun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umputun umputun merged commit 6449b7d into master Nov 1, 2021
@umputun umputun deleted the paskal/telegram_notify branch November 1, 2021 19:35
@paskal paskal added this to the v1.9 milestone Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants