Multiple notify module improvements #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/notify_improvements
branch
from
deb0bac to
557332c
Compare
paskal
force-pushed
the
paskal/notify_improvements
branch
from
557332c to
23a101d
Compare
Codecov Report
@@ Coverage Diff @@
## master #1048 +/- ##
=======================================
Coverage 44.18% 44.18%
=======================================
Files 126 126
Lines 2904 2904
Branches 653 653
=======================================
Hits 1283 1283
Misses 1609 1609
Partials 12 12 Continue to review full report at Codecov.
|
umputun
reviewed
Jun 14, 2021
| b, err := json.Marshal(body) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| return b, nil | ||
| } | ||
|
|
||
| func escapeTitle(title string) string { | ||
| escSymbols := []string{"[", "]", "(", ")"} | ||
| func escapeText(title string) string { |
There was a problem hiding this comment.
I'm not sure about this one. The original ticket for all this escaping indicated no improvement for the initial problem #839
unless you see something really helpful due to this, I suggest dropping it completely
There was a problem hiding this comment.
I saw messages not sending without escaping, status code 400. We can't drop it according to my tests with the verify messages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A couple of changes to telegram notifications and error handling code, email text improvements, ignore IntelliJ Idea rest requests variables file.
Reply notification text, now more consistent with the email notification, and the same which will be used for user notifications. Before:
After:
Part of #1029 is not strictly tied to the telegram user notifications, and I wanted to merge separately.