Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI localization support #10

Closed
umputun opened this issue May 12, 2018 · 8 comments · Fixed by #638
Closed

UI localization support #10

umputun opened this issue May 12, 2018 · 8 comments · Fixed by #638
Assignees
@paskal
Labels
enhancement frontend help wanted
Milestone
v1.6

Comments

@umputun
Copy link
Owner

umputun commented May 12, 2018

All texts in UI should be defined in some file and we need the ability to pass a custom file.
@Menelion
Copy link
Contributor

Ideally, this should be a mature localization solution supporting also date formatting, HTML lang attribute changing and all the nitty-gritty stuff.

This seems to be quite a good solution for Preact.
The dates can be formatted with Luxon, for example.

@umputun
Copy link
Owner Author

umputun commented May 13, 2018

dates look ... unusual to me. For example 13.05.18 at 11:32 will be very confusing to anyone living with MM-DD-YY standard

@Menelion
Copy link
Contributor

DateTime.local().setLocale('en-US').toLocaleString()? :) Anyway, @igoradamenko, what do you think of all this?

@igoradamenko
Copy link
Collaborator

I understand that current date format may be unusual for people from Europe, USA, etc. I used the most popular format in my country, but with English. I did it in this way, because i18n is complicated on the first steps and we had a lot of things to do. And because first Remark42 users are from Russia, Ukraine and other Russian speaking countries.

DateTime is a part of Intl API, which isn't supported in iOS Safari < 10. It's not a big problem, but it means that we need to remember about fallbacks and other stuff like this.

BTW, I wanted to add time format like 5 minutes ago and similar, because it's more useful than regular date. But the regular date can be inside title attribute, because sometimes users want to get exact date. And it may be in format that user has used to see, sure.

So, yeah, we will improve i18n for dates :-)

@umputun umputun added this to the v1.1 milestone May 31, 2018
@igoradamenko igoradamenko removed their assignment Jun 19, 2018
@umputun umputun modified the milestones: v1.1, v1.2 Jan 6, 2019
@umputun umputun removed this from the v1.2 milestone Jan 21, 2019
@igoradamenko igoradamenko mentioned this issue Jan 27, 2019
Closed
@umputun umputun mentioned this issue Nov 6, 2019
Closed
@BarryRufer
Copy link

Is there any progress on this? Or do I need to manually edit web/remark.js?

@umputun umputun added this to the v1.6 milestone Jan 22, 2020
@codiflow
Copy link
Contributor

codiflow commented Feb 15, 2020 •
edited
Loading

I translated the whole thing to German.

At the moment I copied all files from inside the docker container (folder "/srv/web") to my host and mapped another volume in my docker-compose.yml like this:

volumes:
- ./web:/srv/web

So I could modify everything without loosing my changes after a container restart.

If theres a deadline for 1.6 I would contribute my German translation.

Mavrin added a commit to Mavrin/remark that referenced this issue Feb 17, 2020
@Mavrin
umputun#10 add localization
647dacf
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 17, 2020
@Mavrin
umputun#10 add localization
8cf36b8
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 17, 2020
@Mavrin
umputun#10 add localization
0b153d2
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 17, 2020
@Mavrin
umputun#10 add localization
b8e2520
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 17, 2020
@Mavrin
umputun#10 revert locale from dev page
5706b3f
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 17, 2020
@Mavrin
umputun#10 add more examples
0ea9a48
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 18, 2020
@Mavrin
umputun#10 localize auth panel
f2d4d79
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 18, 2020
@Mavrin
umputun#10 localize some comment message
8af1e0d
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 18, 2020
@Mavrin
umputun#10 localize some comment form message
b6f7f93
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 19, 2020
@Mavrin
umputun#10 translate vote messages
bde6a9b
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 19, 2020
@Mavrin
umputun#10 translate comment message
0bea25b
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 19, 2020
@Mavrin
umputun#10 use messages value for translate reference
258ed69
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 use messages value for translate reference
071804b
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 use messages value for translate reference
d0e0e43
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 use messages value for translate reference
a359bc6
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate comment message
f1578a2
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate comment form
302fbaa
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate comment form
05ae8cf
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate root component
b4402de
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate user info
c848581
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate settings
acf9f57
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate settings
f11c48c
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate toolbar
32f0322
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 translate errors messages
14ce267
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 sort dict
3ae5ac5
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 fix after rebase
36bd40f
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 localize anonymousLoginForm
6277fbe
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 localize emailLoginForm
db35489
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 update size-limit
bfe8e53
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 localize subscribe by rss
b4cdb1e
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 localize subscribe by email
3399eb8
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 add de locale
708e655
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 22, 2020
@Mavrin
umputun#10 increase limit size
c2991ed
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 23, 2020
@Mavrin
umputun#10 auto generate loadLocale
b772713
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 23, 2020
@Mavrin
umputun#10 auto generate loadLocale
55c19c0
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 23, 2020
@Mavrin
umputun#10 add some documentation
da94f26
Mavrin added a commit to Mavrin/remark that referenced this issue Feb 23, 2020
@Mavrin
umputun#10 fix error messages
3b2a01c
umputun added a commit that referenced this issue Mar 4, 2020
@umputun
Add localization (#602)
b22cd5f 
* #10 add localization

* #10 revert locale from dev page

* #10 add more examples

* #10 localize auth panel

* #10 localize some comment message

* #10 localize some comment form message

* #10 translate vote messages

* #10 translate comment message

* #10 use messages value for translate reference

* #10 fix compile issue

* #10 use messages value for translate reference

* #10 use messages value for translate reference

* #10 use messages value for translate reference

* #10 use messages value for translate reference

* #10 use messages value for translate reference

* #10 translate comment message

* #10 translate comment form

* #10 translate comment form

* #10 translate root component

* #10 translate user info

* #10 translate settings

* #10 translate settings

* #10 translate toolbar

* #10 translate errors messages

* #10 sort dict

* #10 fix after rebase

* #10 localize anonymousLoginForm

* #10 localize emailLoginForm

* #10 update size-limit

* #10 localize subscribe by rss

* #10 localize subscribe by email

* #10 add de locale

* #10 increase limit size

* #10 auto generate loadLocale

* #10 add some documentation

* #10 fix error messages

* fix typo

* don't bundle en locale

* fix message id

* change size limits

* Update extract message pattern

Co-Authored-By: Pavel Mineev <[email protected]>

Co-authored-by: Pavel Mineev <[email protected]>
@paskal
Copy link
Collaborator

paskal commented Mar 9, 2020

Translation support is added in #602, I will prepare a PR with documentation on contibuting translations and resolve this issue then.

@paskal paskal self-assigned this Mar 9, 2020
@paskal paskal mentioned this issue Apr 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paskal paskal

Labels
enhancement frontend help wanted
Projects
None yet
Milestone
v1.6
Development

Successfully merging a pull request may close this issue.

Add translation instructions umputun/remark42
6 participants
@umputun @Menelion @paskal @igoradamenko @codiflow @BarryRufer