Skip to content

Commit

Permalink
remove explicit /srv/ usage from docker-compose files
Browse files Browse the repository at this point in the history
We have plenty of paths used in the application, but two of them
are hardcoded in examples all over the code for historical reasons.

I found that by default in Docker, the path would resolve to the value
we are setting it explicitly to, so it doesn't make sense to set
a few variables we are setting now explicitly.
  • Loading branch information
paskal authored and umputun committed Feb 7, 2022
1 parent e0980d4 commit 9dbc36e
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 13 deletions.
1 change: 0 additions & 1 deletion backend/_example/memory_store/compose-dev-memstore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ services:
environment:
- REMARK_URL=http://127.0.0.1:8080
- SECRET=123456
- BACKUP_PATH=/srv/var/backup
- DEBUG=true
- EMOJI=true
- AUTH_ANON=true
Expand Down
2 changes: 0 additions & 2 deletions compose-dev-backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,6 @@ services:
# - TIME_ZONE=GMT
- REMARK_URL=http://127.0.0.1:8080
- SECRET=12345
- STORE_BOLT_PATH=/srv/var/db
- BACKUP_PATH=/srv/var/backup
- DEBUG=true
- ADMIN_PASSWD=password
- AUTH_DEV=true # activate local oauth "dev"
Expand Down
2 changes: 0 additions & 2 deletions compose-dev-frontend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@ services:
environment:
- REMARK_URL=http://127.0.0.1:8080
- SECRET=12345
- STORE_BOLT_PATH=/srv/var/db
- BACKUP_PATH=/srv/var/backupang
- DEBUG=true
- ADMIN_PASSWD=password
- AUTH_DEV=true # activate local oauth "dev"
Expand Down
2 changes: 0 additions & 2 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ services:
environment:
- REMARK_URL
- SECRET
- STORE_BOLT_PATH=/srv/var/db
- BACKUP_PATH=/srv/var/backup
- DEBUG=true
- AUTH_GOOGLE_CID
- AUTH_GOOGLE_CSEC
Expand Down
4 changes: 0 additions & 4 deletions site/src/docs/manuals/kubernetes/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,6 @@ spec:
secretKeyRef:
name: remark42
key: SECRET
- name: STORE_BOLT_PATH
value: "/srv/var/db"
- name: BACKUP_PATH
value: "/srv/var/backup"
- name: AUTH_GOOGLE_CID
valueFrom:
secretKeyRef:
Expand Down
2 changes: 0 additions & 2 deletions site/src/docs/manuals/reproxy/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,6 @@ services:
- SECRET=some-secret-thing
- USER=app
- REMARK_URL=https://remark42.example.com
- STORE_BOLT_PATH=/srv/var
- BACKUP_PATH=/srv/var/backup
- CACHE_MAX_VALUE=10000000
- IMAGE_PROXY_HTTP2HTTPS=true
- AVATAR_RESIZE=48
Expand Down

0 comments on commit 9dbc36e

Please sign in to comment.