Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: redirect to 404 if none router exact match #697

Merged
merged 3 commits into from
Jul 11, 2018

Conversation

paranoidjk
Copy link
Contributor

@paranoidjk paranoidjk commented Jul 10, 2018

生产环境

路由不 exact 匹配,自动跳转到 /404 (已 revert 247cc32 交由用户代码自行在项目 Layout 里面添加)

开发环境

会自动在所有嵌套子路由数组的最后添加 umi not found 页面路由,不做自动跳转

@coveralls
Copy link

coveralls commented Jul 10, 2018

Pull Request Test Coverage Report for Build 786

  • 0 of 12 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 25.712%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/DefaultLayout.js 0 6 0.0%
packages/umi-build-dev/src/plugins/404/index.js 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi-build-dev/src/DefaultLayout.js 1 0.0%
Totals Coverage Status
Change from base Build 762: -0.04%
Covered Lines: 631
Relevant Lines: 2565

💛 - Coveralls

@sorrycc sorrycc changed the base branch from master to 1.x July 11, 2018 02:59
@sorrycc sorrycc changed the base branch from 1.x to master July 11, 2018 03:00
@sorrycc sorrycc merged commit 9e139a3 into umijs:master Jul 11, 2018
@paranoidjk paranoidjk deleted the feat-404 branch July 11, 2018 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants