Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix @babel/preset-env browsers config #632

Merged
merged 1 commit into from
Jun 15, 2018
Merged

fix @babel/preset-env browsers config #632

merged 1 commit into from
Jun 15, 2018

Conversation

yutingzhao1991
Copy link
Contributor

@yutingzhao1991 yutingzhao1991 commented Jun 15, 2018

之前的配置一直是错的, @babel/preset-env 的最新版会做校验导致 build 报错。

配置参考: https://new.babeljs.io/docs/en/next/babel-preset-env.html#targetsbrowsers

另外 umi 里面锁死了 @babel/preset-env 为 7.0.0-beta.46,这个问题暂时不会暴露。

@coveralls
Copy link

coveralls commented Jun 15, 2018

Pull Request Test Coverage Report for Build 671

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 22.225%

Totals Coverage Status
Change from base Build 667: 0.0%
Covered Lines: 526
Relevant Lines: 2607

💛 - Coveralls

@sorrycc sorrycc merged commit 2c586b9 into master Jun 15, 2018
@sorrycc sorrycc deleted the yu-fixpreset branch June 15, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants