-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add umi-plugin-polyfills #517
Conversation
Pull Request Test Coverage Report for Build 471
💛 - Coveralls |
"lib" | ||
], | ||
"dependencies": { | ||
"@babel/polyfill": "^7.0.0-beta.47", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@babel
依赖在正式发布前需要写死版本,用 7.0.0-beta.46
,并且不要用 ^
,和其他库的保持一致,统一测试后升级。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
@@ -0,0 +1,24 @@ | |||
{ | |||
"name": "umi-plugin-routes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name 不对,我觉得叫 umi-plugin-polyfill 比较合适,和 @babel/polyfill 的命名保持一致。
extend 是做啥的?import 额外的 js ? |
现在是否只解决了 IE 10 及以下的兼容问题? |
extend 用于加入其他的兼容文件,支持直接写模块名,支持本地相对应根目录的文件路径。 |
再加个 README.md 介绍下用途吧。 |
@@ -0,0 +1,24 @@ | |||
{ | |||
"name": "umi-plugin-routes", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里只用\n是不是好些?
* refactor(plugins): export getter from initial state plugin * refactor(preset-umi): init history before patch routes * feat(plugins): support to render exception for layout * feat(plugins): provide runtime component from access plugin * feat(plugins): support to handle access for each route * revert(plugins): export getter from initial state plugin This reverts commit 0c40911241649e2f2ffe197ebb3e99a53b0097fc. * revert(plugins): support to handle access for each route This reverts commit f37302f9d6e93c0cfa525fc656d3ac823d6d4dbc. * feat(plugins): export marked routes hook from access plugin * refactor(plugins): use access marked routes in layout plugin * revert(preset-umi): init history before patch routes This reverts commit c219fd631c0ac99b6e0fbf1762e59958850cd1b9. Co-authored-by: Peach <[email protected]>
* refactor(plugins): export getter from initial state plugin * refactor(preset-umi): init history before patch routes * feat(plugins): support to render exception for layout * feat(plugins): provide runtime component from access plugin * feat(plugins): support to handle access for each route * revert(plugins): export getter from initial state plugin This reverts commit 0c40911241649e2f2ffe197ebb3e99a53b0097fc. * revert(plugins): support to handle access for each route This reverts commit f37302f9d6e93c0cfa525fc656d3ac823d6d4dbc. * feat(plugins): export marked routes hook from access plugin * refactor(plugins): use access marked routes in layout plugin * revert(preset-umi): init history before patch routes This reverts commit c219fd631c0ac99b6e0fbf1762e59958850cd1b9. Co-authored-by: Peach <[email protected]>
defined import @babel/polyfill setprototypeof
use case:
.umirc.js
or
extend must be a array ,defined null,
extend:['model name','./src/polyfills.js']
#413