Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact: routes #414

Merged
merged 8 commits into from
May 6, 2018
Merged

refact: routes #414

merged 8 commits into from
May 6, 2018

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented May 3, 2018 •
edited by xiaohuoni
Loading

  • refact routes
  • read routes
  • 90%+ coverage for routes related files
  • redirect route
  • 404

@coveralls
Copy link

Pull Request Test Coverage Report for Build 285

  • 0 of 6 (0.0%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-3.9%) to 0.701%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/Service.js 0 1 0.0%
packages/umi/src/renderRoutes.js 0 2 0.0%
packages/umi-build-dev/src/FilesGenerator.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi/src/renderRoutes.js 1 0.0%
packages/umi-build-dev/src/constants.js 9 0.0%
Totals Coverage Status
Change from base Build 283: -3.9%
Covered Lines: 10
Relevant Lines: 1688
💛 - Coveralls

@coveralls
Copy link

coveralls commented May 3, 2018 •
edited
Loading

Pull Request Test Coverage Report for Build 319

  • 0 of 4 (0.0%) changed or added relevant lines in 3 files are covered.
  • 100 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+4.6%) to 9.244%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi/src/renderRoutes.js 0 1 0.0%
packages/umi-build-dev/src/Service.js 0 1 0.0%
packages/umi-build-dev/src/FilesGenerator.js 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi-build-dev/src/UserConfig.js 2 0.0%
packages/af-webpack/src/dev.js 18 0.0%
packages/umi-build-dev/src/FilesGenerator.js 34 11.76%
packages/umi-build-dev/src/Service.js 46 0.0%
Totals Coverage Status
Change from base Build 283: 4.6%
Covered Lines: 112
Relevant Lines: 1584
💛 - Coveralls

@yutingzhao1991
Copy link
Contributor

@zinkey

@sorrycc sorrycc changed the title [WIP] refact: routes refact: routes May 6, 2018
@sorrycc sorrycc merged commit 3833b03 into master May 6, 2018
@sorrycc sorrycc deleted the refact/routes branch May 6, 2018 00:18
sorrycc pushed a commit that referenced this pull request Jun 23, 2022
@YdreamW @sorrycc
fix: plugin key should be non-conflict (#414)
bb9ce45 
* fix: allow hooks registered by the add-type registerMethod to return individual values.

* fix: plugin key should be non-conflict

* chore: use plugin key instead of id to be hook's name

* chore(skipPlugins): use plugin key instead of id

* chore(skipPlugins): feat assert
xierenyuan pushed a commit to xierenyuan/umi that referenced this pull request Jun 23, 2022
@YdreamW
fix: plugin key should be non-conflict (umijs#414)
200488b 
* fix: allow hooks registered by the add-type registerMethod to return individual values.

* fix: plugin key should be non-conflict

* chore: use plugin key instead of id to be hook's name

* chore(skipPlugins): use plugin key instead of id

* chore(skipPlugins): feat assert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type(enhancement)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorrycc @coveralls @yutingzhao1991