Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(umi-build-dev): Compiling... problem when request /index.html #383

Merged
merged 1 commit into from
Apr 25, 2018
Merged

fix(umi-build-dev): Compiling... problem when request /index.html #383

merged 1 commit into from
Apr 25, 2018

Conversation

sorrycc
Copy link
Member

@sorrycc sorrycc commented Apr 25, 2018

(dirty fix, should be refact later)

introduced by #372

@coveralls
Copy link

Pull Request Test Coverage Report for Build 247

  • 0 of 11 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 4.689%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/FilesGenerator.js 0 4 0.0%
packages/umi-build-dev/src/createRouteMiddleware.js 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi-build-dev/src/createRouteMiddleware.js 1 0.0%
Totals Coverage Status
Change from base Build 245: -0.02%
Covered Lines: 80
Relevant Lines: 1736
💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 247

  • 0 of 11 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 4.689%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/umi-build-dev/src/FilesGenerator.js 0 4 0.0%
packages/umi-build-dev/src/createRouteMiddleware.js 0 7 0.0%
Files with Coverage Reduction New Missed Lines %
packages/umi-build-dev/src/createRouteMiddleware.js 1 0.0%
Totals Coverage Status
Change from base Build 245: -0.02%
Covered Lines: 80
Relevant Lines: 1736
💛 - Coveralls

@sorrycc sorrycc merged commit 8ca8a80 into master Apr 25, 2018
@sorrycc sorrycc deleted the fix/compiling-problem branch April 25, 2018 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type(bug)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sorrycc @coveralls