-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 修复sass/less-loader的路径解析 #1771
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1771 +/- ##
=======================================
Coverage 53.04% 53.04%
=======================================
Files 190 190
Lines 18974 18974
=======================================
Hits 10065 10065
Misses 8909 8909 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
.catch((err: any) => { | ||
throw new Error(err.toString()); | ||
}); | ||
return { content: result.css, type: 'css' }; | ||
} | ||
|
||
export { render }; | ||
|
||
function getResolver(compileStringAsync: any) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
看上去是把 sass-loader 做的事又做了一遍,不知道有没有更好的解法,比如:
- 直接依赖 sass-loader 设法复用相关逻辑
- 搞个适配层直接用 sass-loader
- ……
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
close #1767
接入loader-runner层,可直接运行sass/less-loader
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
just ready
Edits