Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(concatente_modules): concatenate from different externals #1005

Merged
merged 2 commits into from
Apr 1, 2024

Conversation

stormslowly
Copy link
Member

@stormslowly stormslowly commented Apr 1, 2024

语句替换应该从 index 大的开始,所以需要 reverse

Summary by CodeRabbit

  • New Features
    • Reversed iteration order in external_transformer.rs for improved performance.
    • Added mappings for external2 in external_transformer.rs.
    • Introduced test assertions in expect.js for build result validation.
    • Added export of named module qux in external1.js.
    • Exported an object with property bar in external2.js.
    • Imported values from root.js in index.js for validation.
    • Exported constant foo with value 1 in inner.js.
    • Specified entry point and optimization settings in mako.config.json.
    • Exported named variables foo, qux, and bar in root.js.

Copy link
Contributor

coderabbitai bot commented Apr 1, 2024

Walkthrough

The changes involve enhancing module concatenation in the farm_tree_shake plugin, introducing new files for exporting named modules from external sources, and adding test assertions for build results and content checks.

Changes

File Path Summary
crates/mako/src/plugins/farm_tree_shake/shake/module_concatenate/external_transformer.rs Reversed replaces iteration order, added mappings for external2, and new tests for multiple exports.
e2e/fixtures/mako.scope-hoisting.export_named_from_external/ Introduces various new files for exporting named modules and configuring project settings.

Poem

In the code's dance, new steps take flight,
Modules named in the soft moonlight.
Tests assert, files intertwine,
A rabbit's joy in lines divine. 🐇✨

Note

Pull Request Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://coderabbit.ai


Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@stormslowly stormslowly merged commit 1c3bce7 into master Apr 1, 2024
8 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/conatenate_with_mult_external branch April 1, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant