Update and remove unnecessary package dependencies #15268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
While updating dependencies on our commercial products, I noticed the version of
Microsoft.SourceLink.GitHubwas bumped from 1.1.1 to 8.0.0 and looking at the release notes, it's now included in .NET 8 SDK and enabled by default. This means the explicit package reference can be removed and because theEmbedUntrackedSourcesproperty is now also enabled by default (see SDK target), so that one could be cleaned up as well.I've also removed the AngleSharp package reference from
Umbraco.Tests.UnitTests, since only a customGetItemByIndex()extension method from that library was used (which is easily replaced byElementAt().Finally, the following package dependencies have also been updated (to versions that support .NET 8):
Testing can be done by inspecting whether the NuGet packages still contain the GitHub repository URL and separate
snupkgsymbol packages are created.