feat: change package template to use razor class library

[Mantus667]

Prerequisites

• I have added steps to test this contribution in the description below

Description

• Use a RCL as base for the umbraco package template.
• Set v10.0.0 as default version for the package template

Usage of RCLs as base of Umbraco Packages is discussed in multiple occasions in the last month.
Most of the official Umbraco packages moved to be RCLs.
The most important part is the automatic handling of assets which was handled before with the custom build task.

In the last package team meeting we discussed to provide a PR to change the template.

[github-actions]

Hi there @Mantus667, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[abjerner]

Probably a good idea, but a few things to consider:

• Not all packages have assets (but probably doesn't hurt anyways if they are RCLs)

• If RCLs become officially recommended by Umbraco (not sure if they are now), RCL should also be supported by Umbraco. I don't have a good overview of what parts are still missing. Most areas are properly fine, but these aren't:

  • package.manifest files are not picked up from virtual directories - see https://dev.to/kevinjump/umbraco-10-razor-class-library-packages-pt3-40bb

  • SVG icon files are not picked up from virtual directories - see my PR here Added support for virtual backoffice icons #12833

[Mantus667]

@abjerner

Yes indeed, there are things to consider. As you mentioned the package.manifest loading and svg loading.
We discussed this in our last package team meeting and are currently looking if we find (all) spots where changes would be required. There should be some more. Most part where the IFileProvider isn't used. @KevinJump knows some locations.

So it's an intentional draft PR.

[nul800sebastiaan]

Hey there @Mantus667 - are you still planning to work on this? I think we have an alternative now in https://github.com/LottePitcher/opinionated-package-starter (which is working towards RCLs as well).

Maybe it's a good time to rethink this one, not sure what the packages team is up to for this one at the moment.

[nul800sebastiaan]

Just remembered Ronald might be working on something similar: #13776

[ronaldbarendse]

Just remembered Ronald might be working on something similar: #13776

That PR adds a new umbracopackage-rcl template (instead of changing the existing one), so users can still use the latest umbracopackage template if they want to target v10 (that uses the build targets).

If you want to use RCLs with v10, the Opinionated Umbraco Package Starter Template shows how you can use IManifestFilter to accomplish this in PR LottePitcher/opinionated-package-starter#8, but I recommend sticking to the officially supported methods in the CMS 😄