Added support for key vault storage #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in appsettings. The code now falls back to support "-" instead
|
Fantastic @RachBreeze Thank you! |
|
Released in v2.0.1 |
|
Thank you too @Jeavon |
This was referenced Apr 5, 2021
Jeavon
added a commit
that referenced
this pull request
Apr 6, 2021
Updated README.md to reflect the amends made in PR #182
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is for #125
Azure key vault storage does not support "." or ":" in the key name section in the
<appSettings>element of theweb.config. This PR resolves this by replacing "." or ":" in the key name with "-" as a fallback option.This has been created after a client requested the implementation of Azure key vault falling a pen test review of the site.
Looking forward to hearing your feedback