Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore Shift when comparing character keys #117

Closed
ulyssa opened this issue Jun 17, 2023 · 0 comments
Closed

Ignore Shift when comparing character keys #117

ulyssa opened this issue Jun 17, 2023 · 0 comments
Assignees

Comments

@ulyssa
Copy link
Owner

ulyssa commented Jun 17, 2023

Someone reported issues with pressing : on Windows over at ulyssa/iamb#109. The issue there is that modifiers contains KeyModifiers::SHIFT on Windows, but not on other platforms, because of differences in how crossterm constructs the value. Since SHIFT isn't important for comparing KeyCode::Char keypresseses, I should be able to just remove it when constructing TerminalKey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant