Add --hard-fail argument to benchmarks for CI errors
#8513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will cause CI to fail on a benchmark failure for given indices.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
glenn-jocher
changed the title
--hard-fail list argument to benchmarks for CI--hard-fail argument to benchmarks for CI errors
Shivvrat
pushed a commit
to Shivvrat/epic-yolov5
that referenced
this pull request
Jul 12, 2022
) * Add `--hard-fail` list argument to benchmarks for CI Will cause CI to fail on a benchmark failure for given indices. * Update ci-testing.yml * Attempt Failure (CI should fail) * Update benchmarks.py * Update export.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update benchmarks.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update ci-testing.yml * Update benchmarks.py * Update benchmarks.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
) * Add `--hard-fail` list argument to benchmarks for CI Will cause CI to fail on a benchmark failure for given indices. * Update ci-testing.yml * Attempt Failure (CI should fail) * Update benchmarks.py * Update export.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update benchmarks.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update ci-testing.yml * Update benchmarks.py * Update benchmarks.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will cause CI to fail on a benchmark failure (currently no hard errors are thrown, only warnings).
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved error handling and model exporting options in YOLOv5 workflows.
📊 Key Changes
--hard-failoption in benchmarking script to enable throwing errors for benchmark failures.--hard-failflag in the Continuous Integration (CI) benchmarking workflow.🎯 Purpose & Impact
--hard-failoption, developers can more easily detect and handle issues during automated benchmarking, leading to more robust CI processes.