-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace openvino-dev
with OpenVINO Runtime inference
#7843
Replace openvino-dev
with OpenVINO Runtime inference
#7843
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @GabrielDornelles, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
@GabrielDornelles thanks for the PR! Is there a way to use the openvino package for export also instead of openvino-dev? Lines 171 to 187 in 2b64b45
|
for more information, see https://pre-commit.ci
I believe yes, I uninstalled dev package and the command works the same way in the non-dev package. The only thing is that it doesn't have a |
@GabrielDornelles looking at these two it seems that we still need openvino-dev for export: I'll take a closer look |
openvino-dev
with OpenVINO Runtime inference
@GabrielDornelles PR is merged. I validated PR and master exported OpenVINO models and saw same mAP. Also openvino-dev install provides for import openvino, so no changes needed by default for existing users. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
) * Uses OpenVINO runtime instead of openvino-dev * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * export with openvino package * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert export.py * Update common.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Glenn Jocher <[email protected]>
) * Uses OpenVINO runtime instead of openvino-dev * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * export with openvino package * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Revert export.py * Update common.py Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Glenn Jocher <[email protected]>
One of OpenVINO use cases is to run it on Raspberry devices. I'm proposing to make the inference using openvino.runtime, which is installable at raspberry and is available at latest openvino package (tested with openvino==2022.1.0).
The previous inference using openvino-dev was not usable at devices where the dev package is not available.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Improved OpenVINO integration in YOLOv5's model loading and inference.
📊 Key Changes
openvino-dev
toopenvino
.Core
instead ofIECore
.🎯 Purpose & Impact