-
-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow --dynamic
when --half
is passed
#7669
Merged
glenn-jocher
merged 2 commits into
ultralytics:master
from
dmatos2012:add-half-arg-constrain
May 2, 2022
Merged
Disallow --dynamic
when --half
is passed
#7669
glenn-jocher
merged 2 commits into
ultralytics:master
from
dmatos2012:add-half-arg-constrain
May 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @dmatos2012, thank you for submitting a YOLOv5 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with upstream/master. If your PR is behind upstream/master an automatic GitHub Actions merge may be attempted by writing /rebase in a new comment, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
# git checkout feature # <--- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f
- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
glenn-jocher
approved these changes
May 2, 2022
--dynamic
when --half
is passed
2 tasks
@dmatos2012 PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
tdhooghe
pushed a commit
to tdhooghe/yolov5
that referenced
this pull request
Jun 10, 2022
* disallow dynamic arg when half is given * Update export.py Co-authored-by: David Matos <[email protected]> Co-authored-by: Glenn Jocher <[email protected]>
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* disallow dynamic arg when half is given * Update export.py Co-authored-by: David Matos <[email protected]> Co-authored-by: Glenn Jocher <[email protected]>
ctjanuhowski
pushed a commit
to ctjanuhowski/yolov5
that referenced
this pull request
Sep 8, 2022
* disallow dynamic arg when half is given * Update export.py Co-authored-by: David Matos <[email protected]> Co-authored-by: Glenn Jocher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Add this
assertion
when dynamic is given as well as the--half
argument to avoid the error as mentioned in issue #7641.🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhanced compatibility checks in YOLOv5 model export script.
📊 Key Changes
export.py
that prevents using the--half
precision flag in conjunction with the--dynamic
flag during model export.🎯 Purpose & Impact