Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ValueSourcesItems type #1126

Merged
merged 1 commit into from
Nov 3, 2024
Merged

fix ValueSourcesItems type #1126

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/core/modules/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ export type AnyRuleProperties = RuleProperties | RuleGroupExtProperties | RuleGr
export type AnyGroupProperties = GroupProperties | SwitchGroupProperties | CaseGroupProperties;
export type ItemProperties = AnyRuleProperties | GroupProperties;

export type TypedValueSourceMap<T> = {
[key in ValueSource]: T;
}

interface ExtraActionProperties {
// note: id can pre-generated for actions addRule, addGroup
id?: string;
Expand Down
3 changes: 1 addition & 2 deletions packages/ui/modules/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import {
ItemType,
ItemProperties,
ValueSource,
TypedValueSourceMap,
ConfigContext, FactoryWithContext, RenderedReactElement, SerializedFunction,
ConjsProps,

Expand Down Expand Up @@ -246,7 +245,7 @@ export interface ProviderProps {
export type ValueSourceItem = {
label: string;
}
type ValueSourcesItems = TypedValueSourceMap<ValueSourceItem>;
type ValueSourcesItems = Array<[ValueSource, ValueSourceItem]>;

export interface ValueSourcesProps {
config?: Config;
Expand Down