Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache in batch_get_item #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

cache in batch_get_item #20

wants to merge 2 commits into from

Conversation

fayland
Copy link
Contributor

@fayland fayland commented May 31, 2013

Hi

it's a simple patch for cache in batch_get_item.

few notes:

  • we do set cache on the returned body. it should not effect any bad but saves get_item too.
  • we only return directly when there isn't any live request. we do not MIX the cache with the live request. (it's more simple than request less and merge the result, but feel free to do the merge).

let me know if you have any issue and I'll be very glad to hear any comments on it.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant