-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please add a co-maintainer #361
Comments
@uiri Any update on this? |
Don't expect any updates until around Halloween. That seems to be the trend that @uiri follows. This is unmaintainable. This package needs forked. And PyPI needs to track the new fork, since this one's just squatting on the |
Some lengthy discussion about alternatives here: |
I've also since switched to tomli. |
I've gone ahead and reached out to @uiri over a separate channel (email). Let's see if I get a response. If I don't, I'm planning on starting a PEP 541 request for maintainership transfer. |
@pradyunsg Is that necessary since |
Well, it would be good to have tomli's implementation ported over to this name TBH. Having the |
It would also be nice if TOML support is ever upstreamed into the Python stdlib, to use the canonical |
It seems like the consensus on hukkin/tomli#141 was against it and I believe it is @pradyunsg 's plan to do so, but just to be clear, I'd aver that the package under the Anecdotal, but at least most, if not all of the number of packages I've authored/maintain that currently use |
I did this, and @uiri has responsed on that issue stating that the project is not abandoned and they have not had the time to review my request for being added as a maintainer. :) If it helps make this easier for him: here's a list of stuff I do -- https://pradyunsg.me/stuff/ |
@pradyunsg Did anything come of this? Or did @uiri just respond 2 months ago and then went dark again? Maybe it's possible to give the PEP 541 another shot in that case. Simply coming online to deny the PEP can't possibly count as being "reachable" or maintenance. |
Pretty much that, he came online, responded to the PEP 541 request and hasn’t said anything on any of these forums since. |
@pradyunsg I'd say just raise the PEP again (wherever relevant). Busy or not, if someone can't make an hour worth of time in almost a whole year to just quickly evaluate if a person can qualify to be a co-maintainer it's just sad. They don't deserve to squat important package names just to keep their pride. |
And in fact, the author seemingly wouldn't have even have done so, and the PEP 541 request been approved, had I not explicitly pinged them over on that issue (when they had not responded to numerous pings on the issue on their own project over the course of years). So you could say the current situation is at least partially my fault.
Particularly when, up until the author's long hiatus from the responsibilities of maintainership, said package was by far the most widely used Python library for parsing a format of major importance to the Python ecosystem, and the maintainer candidate is the maintainer of the very specification the library implements, one of the most important downstream consumers, and several other prominent Python projects. While one is in no way required to assume the responsibilities of a maintainer, neither should one actively obstruct other worthy individuals from assuming the role, should suitable individuals step up to the plate (and I can't think of anyone more suitable than @pradyunsg ), and while one always strives to assume good faith, it is becoming increasingly difficult to do so given the continued pattern here. |
With https://www.python.org/dev/peps/pep-0680/ accepted for Python 3.11, maintenance of the project will become less of a concern. Plus people can use tomli today if they want to align with what the stdlib is/will be using. |
Added @pradyunsg as a collaborator on this repo. @samvasko and @ryanhiebert are also in the list of co-maintainers, based on their prior contributions. |
Thanks @uiri! Would you also be willing to add folks to the project on pypi.org as owners/maintainers? |
Thanks!
Yeah, that's the big blocker—forking the project on GitHub was the previous plan anyway, but it was the PyPI access that was the subject of pypi/support#1557 . |
To further reduce bus-factor, as a best practice it might also be better to migrate the repo to a GitHub org and adding a couple people (ideally 2-3 total) as owners, rather than having a major project tied to a single GitHub user's personal account (that can get deleted, hacked, etc). |
I'm happy to help be an additional point of contact in this regard if appropriate and desired. I principally maintain a couple of other libraries, and while I don't expect to be directly fixing bugs or writing new code, I can occasionally assist in getting things unstuck for others, and I'm a maintainer on this repo. |
@uiri, will you please consider adding @pradyunsg as a co-maintainer as he's offered multiple times in various issues. He's involved with the TOML language spec itself, the greater Python ecosystem, and appears to have more capacity than you currently do to work issues and pull requests. TOML V1.0 was released and it would be great to implement those updates into this project, e.g. mixed-type arrays.
The text was updated successfully, but these errors were encountered: