Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching from toml to tomli #59

Closed
sobolevn opened this issue Feb 7, 2022 · 2 comments · Fixed by #67
Closed

Consider switching from toml to tomli #59

sobolevn opened this issue Feb 7, 2022 · 2 comments · Fixed by #67
Labels
enhancement New feature or request

Comments

@sobolevn
Copy link
Member

sobolevn commented Feb 7, 2022

toml was last released on 02.11.2020: https://pypi.org/project/toml/#history
There are multiple known bugs: https://github.com/uiri/toml/issues

Maintainer is not supporting their project: uiri/toml#361

Multiple big projects like mypy, black, typeshed have already switched.

The transition seems to be rather simple: basically swap import toml with import tomli and use a proper encoding when calling loads.

Related: https://www.python.org/dev/peps/pep-0680/

If this is something you think should be done, I can send a PR.

@hugovk
Copy link
Member

hugovk commented Mar 20, 2022

PEP 680 has been accepted and will be in Python 3.11 🎉

I think it would be a good idea to switch from from toml to tomli, it will make it easier to switch to the stdlib tomllib at some point in the future.

@hugovk hugovk added the enhancement New feature or request label Mar 20, 2022
@DanielNoord
Copy link
Contributor

Sorry @sobolevn, I didn't notice the last sentence of your post. Not sure if you were already working on this, but I have created a PR which fixes this in #67.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants